Skip to content

Move reporting Firebase user agent from checkin to register #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 31, 2019
Merged

Move reporting Firebase user agent from checkin to register #2679

merged 9 commits into from
Mar 31, 2019

Conversation

@maksymmalyhin
Copy link
Contributor

@maksymmalyhin maksymmalyhin commented Mar 29, 2019

b/124533860

@maksymmalyhin maksymmalyhin marked this pull request as ready for review March 29, 2019 20:15
@maksymmalyhin
Copy link
Contributor Author

maksymmalyhin commented Mar 29, 2019

@chliangGoogle Logging have been tested - it looks working on both staging and prod.

charlotteliang
charlotteliang approved these changes Mar 29, 2019
View reviewed changes
Copy link
Contributor

@charlotteliang charlotteliang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM on travis green

@maksymmalyhin maksymmalyhin merged commit c416b10 into master Mar 31, 2019
@maksymmalyhin maksymmalyhin deleted the mm/iid-register-agent branch April 2, 2019 14:04
Corrob pushed a commit that referenced this pull request Apr 25, 2019
@maksymmalyhin @Corrob
Move reporting Firebase user agent from checkin to register (#2679)
15b1167
@firebase firebase locked and limited conversation to collaborators Oct 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@charlotteliang charlotteliang charlotteliang approved these changes

+1 more reviewer

@davidair davidair davidair approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@maksymmalyhin @davidair @charlotteliang @googlebot